On 2026-04-10 Fr 3:57 AM, Thomas Munro wrote:
Nitpicking code review for commit b15c1513:
+read_archive_wal_page(XLogDumpPrivate *privateInfo, XLogRecPtr targetPagePtr,
+ Size count, char *readBuff)
I thought we agreed to stop using Size for new code? size_t has been
around since C89.
Must have missed the memo :-(
+ pg_fatal("WAL segment \"%s\" in archive \"%s\" is too short: rea
d %lld of %lld bytes",
+ fname, privateInfo->archive_name,
+ (long long int) (count - nbytes),
+ (long long int) count);
Why cast to long long int? That's the sort of thing we used to have
to do for int64 (but no longer), but here it's size_t anyway. %zu has
been around since C99.
will fix. Thanks for looking.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
