On 2026-04-10 Fr 10:17 AM, Andres Freund wrote:
Hi,
On April 10, 2026 3:57:56 AM EDT, Thomas Munro <[email protected]> wrote:
Nitpicking code review for commit b15c1513:
+read_archive_wal_page(XLogDumpPrivate *privateInfo, XLogRecPtr targetPagePtr,
+ Size count, char *readBuff)
I thought we agreed to stop using Size for new code? size_t has been
around since C89.
We really need to start documenting some of this stuff somewhere. Deciding
something a few years ago, deep in a thread, won't actually help anyone but the
participants (and maybe not even them) to know about it.
I wonder if we should move the coding style section out of sgml into a
top-level CODING_STYLE.md or something like that.
And then obviously add things like Size being deprecated.
+many. Great idea.
cheers
andew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
