> On May 4, 2026, at 22:47, Peter Eisentraut <[email protected]> wrote:
>
> On 29.04.26 14:58, Chao Li wrote:
>> As Alvaro commented at [1], I added 0003 to use OidIsValid macro. 0001 and
>> 0002 are unchanged.
>> [1]https://www.postgresql.org/message-id/02fe13db-4fba-4e9d-9b4c-
>> [email protected]
>
> I'm personally not on board with that coding style rule. At least I don't
> consider this patch necessary right now as we're working toward stabilizing
> the current code.
>
In the current code in propgraphcmds.c, the style is already inconsistent. I
see three forms:
At line 434:
```
if (OidIsValid(opc))
```
At line 754:
```
if (!labeloid)
```
At lne 1302:
```
if (pgrelid == InvalidOid)
```
Anyway, I don’t have a strong opinion here, so please feel free to discard 0003.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
