On Fri, May 8, 2026 at 7:28 PM Alvaro Herrera <[email protected]> wrote: > > On 2026-May-08, Amit Kapila wrote: > > > Some issues/inefficiencies regarding this fix and base code related to > > db-specific snapshots built during decoding: [...] > > Thanks for spending time reviewing this code. I think none of these > problems are fundamental in nature, but they are obviously worth > addressing for 19. If we hit some roadblock, we can still revert only > db-specific snapshots. >
IIUC, the emails by Andres [1][2] on db-specific snapshots sound like concerns which are fundamental in nature. Apart from that as well, I think the first point mentioned in my email [3] should be at least addressed as that causes additional WAL even after reaching consistent_state for each runing_xact record for a db-specific decoder. [1] - https://www.postgresql.org/message-id/cdgw4sbbfcgk6du3iv54r2dgiy4tfywoklbotlmj4irxavdcr3%40glxfw5jj277q [2] - https://www.postgresql.org/message-id/pveffyxhnuurhb44uzqlwo3rkyzorkfh2rot7uwzlf2axhfvbp%407nrs2omysxkc [3] - https://www.postgresql.org/message-id/CAA4eK1LygCDP3FiFzXY9iVNFcHxhf7TT_DFf7tryTu2oipmfpA%40mail.gmail.com -- With Regards, Amit Kapila.
