Hi,
On Wed, May 13, 2026 at 4:27 PM Zhenwei Shang <[email protected]> wrote:
> Ayush Tiwari <[email protected]> 于2026年5月12日周二 16:03写道：
>> On Tue, 12 May 2026 at 13:06, Etsuro Fujita <[email protected]> wrote:
>>> One thing I noticed is the test case you added; it only tests
>>> departing column names with single quotes, but it's better to also
>>> test that with backslashes, to confirm the patch addresses the issue
>>> in [1] as well. So I updated the patch as such. New version
>>> attached. Other than that the patch looks good to me, so I'll push it
>>> if no objections from you (or anyone else).
>> Thanks for the updated version, and for folding in the backslash case
>> from [1].
>>
>> I confirmed that the patch applies cleanly on master and that
>> make -C contrib/postgres_fdw check passes, including the new
>> dtest_ftable case. The merged test seems a strict improvement.
>>
>> No objections from me.
Cool! Thanks for double-checking, Ayush!
> The patch overall looks solid to me. A tiny suggestion, while here, would it
> make sense to also add comma and brace column names to the test, as they are
> classic array-literal hazards, like “col,comma” and “col{brace”?
Those cases are handled correctly even without the patch, so sorry, I
don't feel the need to extend the test further.
Anyway, thanks for reviewing, Zhenwei!
Best regards,
Etsuro Fujita
