Hi, On Wed, May 27, 2026 at 1:12 AM Fujii Masao <[email protected]> wrote:
> On Wed, May 27, 2026 at 1:31 PM SATYANARAYANA NARLAPURAM > <[email protected]> wrote: > > Thank you for the changes and review. > > When I applied the v4 patch together with Shveta's diff patch and > ran the regression tests, the tests failed. > > Could pg_create_physical_replication_slot() still have the same issue > if it throws an error after ReplicationSlotCreate() and that error is > caught by a PL/pgSQL EXCEPTION block > Also, do maybe pg_copy_physical_replication_slot(), > pg_drop_replication_slot(), > and ALTER_REPLICATION_SLOT potentially have the same issue as well? > Addressed these in v5 patch, will send out shortly. ALTER_REPLICATION_SLOT is not exploitable by a SQL query though it has a similar signature. A walsender error terminates the session so there is no session to leave in a bad state.
