On Thu, May 28, 2026 at 10:19 AM Daniel Gustafsson <[email protected]> wrote: > > On 28 May 2026, at 05:16, Kyotaro Horiguchi <[email protected]> wrote: > >> libpq_append_conn_error(conn, > >> "server did not report the unsupported `_pq_.test_protocol_negotiation` > >> parameter in its protocol negotiation message"); > > > > but that doesn't seem to match our usual style. Nearby messages use > > double quotes instead. > > Agreed. Shouldn't it also be adding the parameter as a %s to further match > our style? > > - libpq_append_conn_error(conn, "server did not report the unsupported > `_pq_.test_protocol_negotiation` parameter in its protocol negotiation > message"); > + libpq_append_conn_error(conn, "server did not report the unsupported > \"%s\" parameter in its protocol negotiation message", > "_pq_.test_protocol_negotiation");
+1, will fix. Thanks! --Jacob
