Hi Horiguchi-san, On Thu, May 28, 2026 at 8:46 AM Kyotaro Horiguchi <[email protected]> wrote: > > Hello, > > While translating error messages into Japanese, I came across some > unusually formatted messages and messages that are difficult to > translate naturally into Japanese. > > 0001: 0001-Make-propgraph-object-descriptions-translatable.patch > > getObjectDescription() currently builds the object name for > PropgraphElementRelationId incrementally with appendStringInfo(), but > that works poorly with Japanese because it effectively fixes the word > order. We probably need to construct the whole name from a single > format string instead. >
Sorry for delay in review. Few comments 1. There are other places in the function where we use similar code. Those places call initStringInfo just before getRelationDescription() is called and then pfree() StringInfoData.data after it is added to the object description. 2. Why do we want to capture the output of getObjectDescription() in a StringInfo and then add it to the buffer? I think we can pass getObjectDescription directly as an argument to appendStringInfo() similar to the code for case AttrDefaultRelationId. -- Best Wishes, Ashutosh Bapat
