Re: Adding REPACK [concurrently]

[Antonin Houska]

This is a diff to remove a comment that was only valid in earlier versions of
the patch - I failed to notice that so far. Another comment in
copy_table_data() explains why rd_toastoid is not set in the CONCURRENTLY
mode:

         * This would not work with CONCURRENTLY because we may need to delete
         * TOASTed tuples from the new heap. With this hack, we'd delete them
         * from the old heap.
         */
        NewHeap->rd_toastoid = OldHeap->rd_rel->reltoastrelid;


-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


diff --git a/src/backend/commands/repack.c b/src/backend/commands/repack.c
index 4d177c868bb..195d85c323b 100644
--- a/src/backend/commands/repack.c
+++ b/src/backend/commands/repack.c
@@ -1453,8 +1453,6 @@ copy_table_data(Relation NewHeap, Relation OldHeap, Relation OldIndex,
 
 	/*
 	 * Reset rd_toastoid just to be tidy --- it shouldn't be looked at again.
-	 * In the CONCURRENTLY case, we need to set it again before applying the
-	 * concurrent changes.
 	 */
 	NewHeap->rd_toastoid = InvalidOid;