Hi all, One small follow-up on top of v50.
Master recently reworded the error raised when RESPECT/IGNORE NULLS is used on a non-window function, from "only window functions accept RESPECT/IGNORE NULLS" to "RESPECT/IGNORE NULLS specified, but %s is not a window function". rpr_base was written before that change, so one expected-output line now mismatches and the test fails on current master. The attached patch updates just that line. No code or behavior change. I'm sending it as a separate attachment so the v50 series stays as posted; it applies on top of v50-0020. Best, Henson
From c238d80cd76d57c7d1dbde864f70258f50494c1f Mon Sep 17 00:00:00 2001 From: Henson Choi <[email protected]> Date: Thu, 25 Jun 2026 22:39:36 +0900 Subject: [PATCH v50] Adjust rpr_base expected output for refined IGNORE NULLS error Commit 419ce13b701 refined the error reported when RESPECT/IGNORE NULLS is used on a non-window function, changing it from "only window functions accept RESPECT/IGNORE NULLS" to "RESPECT/IGNORE NULLS specified, but %s is not a window function". The rpr_base test was added before that refinement and kept the old wording, so update its expected output to match. No behavior change. --- src/test/regress/expected/rpr_base.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/regress/expected/rpr_base.out b/src/test/regress/expected/rpr_base.out index 33fcb40b1a8..7957595ad8b 100644 --- a/src/test/regress/expected/rpr_base.out +++ b/src/test/regress/expected/rpr_base.out @@ -2143,7 +2143,7 @@ SELECT count(*) OVER w FROM nt WINDOW w AS (PARTITION BY g ORDER BY id ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING INITIAL PATTERN (A+) DEFINE A AS PREV(val) IGNORE NULLS IS NULL); -ERROR: only window functions accept RESPECT/IGNORE NULLS +ERROR: RESPECT/IGNORE NULLS specified, but prev is not a window function LINE 4: PATTERN (A+) DEFINE A AS PREV(val) IGNORE NULLS IS NULL)... ^ -- Quoting does not escape: "prev" is nav, "PREV" is an ordinary name -- 2.50.1 (Apple Git-155)
