> On Aug 6, 2026, at 15:09, Hayato Kuroda (Fujitsu) <[email protected]> > wrote: > > Dear Chao, > > Thanks for working on it. I checked your patch and briefly looks good.
Thank you very much for reviewing the patch.
>
> ```
> + if (duplicate_sub_name && num_replslots == 0)
> + {
> + pg_log_error("duplicate subscription names require distinct replication
> slot names");
> + pg_log_error_detail("When replication slot names are not specified,
> subscription names are used, but replication slot names must be unique within
> a cluster.");
> + pg_log_error_hint("Specify a unique --replication-slot name for each
> database.");
> + exit(1);
> + }
> ```
>
> Not sure pg_log_error_detail() is helpful here. Can we remove?
I thought to provide more info, maybe too verbose.
> Also I feel we do not have to clarify "distinct/unique" for replication slot
> names,
> it has already been described other lines.
Okay, removed.
PFA v2 - addressed Hayato-san’s comments.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
v2-0001-pg_createsubscriber-Allow-duplicate-subscription-.patch
Description: Binary data
