Thanks for the report. On Wed, Aug 12, 2026 at 11:52:46AM +0300, Anton Voloshin wrote: > So I suggest an obvious fix, which is needed in REL_14_STABLE..master, > attached.
Yeah, that's an oversight on my part. IIUC this only affects Windows extensions that happen to need the variable, and since it's never been exported in any release thus far, no extension should depend on it yet. Still, marking is the policy, and I see no reason for an exception here. Barring objections, I'll plan on applying this change soon. > P.S. Perhaps CI or buildfarm member running src/tools/mark_pgdllimport.pl > would be a good idea? FWIW I ran the script over all of src/include on master, and it flags exactly two lines: this one, and __pg_log_level in common/logging.h, which is deliberately unmarked (commit 8d33412665). So a check like that seems pretty feasible, provided we have some way to note the exceptions. -- nathan
