The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

I have checked that make installcheck-world does not report any issue: the new 
test case works as expected.

There is no change in SQL so I did not test SQL compliance. I don't think that 
documentation should be changed as this is an optimization change only.

Average execution time of make installcheck-world with patch is 748s.

Average execution time of make installcheck-world without patch is 749,6 s.

This patch review looks easy because there is little code change . However it's 
for more difficult to understand the context if you don't  know what a planned 
support function is (that was my case).

I think this patch should be reviewed by a more experienced contributor with 
query planner skills.

Reply via email to