On Wed, 27 May 2026 at 11:50, Peter Smith <[email protected]> wrote: > > The patch had previously been split for EXCEPT and non-EXCEPT changes. > > The 0001 patch was already pushed a while ago for PG19. I think now > that 0002 patch can be revisited for PG20.
Attached v7 version patch has the changes for the same. This patch is the same as [1], reattaching here so it is easier for review. > ====== > > IMO, the logical replication messages should consistently always give > fully qualified relation names in the error messages. The relation > named in the message can sometimes be ambiguous when not schema > qualified. > > I saw some previous comment from Euler [1] saying we should refrain > from changing existing messages, but IMO here we are not rewording > message text for the sake of it; I think rather it is fixing the > values substituted to the *existing* messages to improve the clarity, > and at the same time making all the logical replication logs more > consistent. But, perhaps I misunderstood Euler's comment: if it was -1 > referring only to backpatching then I agree. > > Anyway, I looked again at the old v5-0002 patch. I found it is only > addressing the issue schema-qualification for > check_publication_add_relation. Actually, I think that is just a very > small part of something far bigger. e.g. There are many more places in > logical replication related code where fully qualified names could be > used. I felt this can be discussed and handled in a separate thread if required. [1] - https://www.postgresql.org/message-id/CALDaNm0YrwGNECBihB-hHOS3E8dhLFHjkPLSxOL-riY-ujGYjw%40mail.gmail.com Regards, Vignesh
v7-0001-Use-schema-qualified-names-in-publication-add-rel.patch
Description: Binary data
