On Fri, Sep 4, 2026 at 6:30 PM Peter Smith <[email protected]> wrote:
>
> Erk. Thankyou for finding that.
>
> I am surprised that patch v4 was able to pass existing regression
> tests with that bug. The \dn test cases must've had some gaps. I have
> added more tests for checking schema case in quoted names.
>
> PSA patch v5.
>
> Also, I changed the CF entry back to "Needs Review" in case there are
> more problems lurking.
Thanks for the updated match with the fixes and the new tests. The fix
works and the new tests are welcome. A few minor comments:
1.
+ for (int i = 0; i < num_schemas; i++)
+ {
+ const char *nspname = PQgetvalue(res, i, 0);
+
+ describeOneSchemaDetails(nspname, verbose);
+ }
+ }
The return value (bool) of describeOneSchemaDetails is ignored. Is it
even required?
2.
The code now allocates memory for title as well but is not freed in
the error path.
+ initPQExpBuffer(&title);
+ printfPQExpBuffer(&title, _("Schema \"%s\""), schemaname);
regards,
Ajin Cherian
Fujitsu Australia
