Kyotaro Horiguchi <[email protected]> writes:
> Commit cb298616463 changed the following line:

> -     printf(_("Latest checkpoint's NextOID:          %u\n"),
> +     printf(_("Latest checkpoint's NextOID:          " OID8_FORMAT "\n"),

> It appears that xgettext does not recognize PostgreSQL's OID8_FORMAT
> macro and therefore extracts only the preceding string literal as the
> msgid. In contrast, PRIu64, which is used in the same file, is
> correctly extracted as %<PRIu64>. Therefore, shouldn't we use "%"
> PRIu64 instead of OID8_FORMAT here as well?

That would be fairly sad, because it means hard-wiring the fact that
Oid8 is the same as uint64 in a bunch of non-obvious places.
Admittedly, we've lived with formatting Oid as %u for a long time.
But can we fix this some other way?

                        regards, tom lane


Reply via email to