> Attached is v2 with those changes. Thoughts? > Hi Ayush.
////////// Patch v2-0001 ////////// Patch 0001 looks good to me, but more eyes than mine need to review it. ////////// Patch v2-0002 ////////// I confirmed the test fails when patch 0001 is not applied and passes when it is applied. I assume the test code is AI-generated, because it looks way less human-readable than a typical TAP test. If the test is ever intended to be pushed, then it needs lots of comments to describe what it is doing and expecting at each step. FWIW, I've attached a copy of that test code augmented with some AI-generated comments. It's still very difficult -- I don't claim to understand everything it is doing -- but the comments might be helpful to somebody. PSA. ====== Kind Regards, Peter Smith. Fujitsu Australia
v2-0002-tests-with-comments.nocfbot
Description: Binary data
