On 2018-Oct-23, Peter Eisentraut wrote: > I propose the attached patch to remove the long-unused catalog column > pg_attrdef.adsrc.
+1, looks good. I think this change has been waiting for a very long time -- documented as useless by 81c41e3d0ed3 (Jan 2005, general doc copy-edit, a paragraph you're now removing). Interestingly, it seems pg_dump stopped relying on that column as a side-effect of 9f0ae0c82060 (May 2002, "First pass at schema-fying pg_dump/pg_restore"); adsrc remained used for 7.1 and older only, which was removed afterwards. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
