On 27/10/2018 23:19, Daniel Gustafsson wrote: >> On 27 Oct 2018, at 12:57, Peter Eisentraut >> <peter.eisentr...@2ndquadrant.com> wrote: >> >> On 23/10/2018 19:48, Daniel Gustafsson wrote: >>>> On 23 Oct 2018, at 15:17, Peter Eisentraut >>>> <peter.eisentr...@2ndquadrant.com> wrote: >>>> >>>> I propose the attached patch to remove the long-unused catalog column >>>> pg_attrdef.adsrc. >>> >>> +1, I ran into a bug in an app as recently as today where adsrc was used >>> instead of pg_get_expr(). >>> >>> Patch looks good. I probably would’ve opted for mentioning how to get a >>> human >>> readable version on the page, along the lines of the attached version, >> >> Agreed. I have integrated your suggestion. >> >> Also, let's go nuts and remove pg_constraint.consrc as well. > > No objections from me. > >> Updated patches attached. > > +1, applies and works as intended.
Committed, thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services