On Wed, Sep 2, 2026 at 2:42 PM Hayato Kuroda (Fujitsu) <[email protected]> wrote: > That's great. I changed the status to "Ready for Committer".
I've started reviewing this patch since it's marked as ready for committer. I have two review comments. + my $pump_timeout = + IPC::Run::timer($PostgreSQL::Test::Utils::timeout_default); This timer is never started or passed to IPC::Run::start(), so it seems it can never expire. Right? If so, isn't it better to reuse the existing timeout for pump_until()? + ok(pump_until($slot_user_handle, $pump_timeout, $to_stderr, + qr/streaming initiated/), + "pg_recvlogical started streaming"); This allows the test to continue even if pump_until() returns false. Since streaming is a prerequisite for the subsequent steps, we should use or die(), as the old code did? Attached 0001 addresses these comments. I also found a pre-existing typo: the slots are created with the prefix "drop_db_", but their removal is checked using "drop_db". Since those names never existed, the checks pass even if the actual slots remain. Attached 0002 fixes this. Regards, -- Fujii Masao
v2-0002-Fix-slot-names-in-the-standby-slot-removal-check.patch
Description: Binary data
v2-0001-Fix-a-race-in-035_standby_logical_decoding.pl.patch
Description: Binary data
nocfbot-v2-0001-PG16_PG17-Fix-a-race-in-035_standby_logical_decoding.pl.patch
Description: Binary data
