> PSA patch v4.

Hi Peter,
Thank you for the patches,
I reviewed the patch v4 and these are minor points, so please feel
free to leave them out if you don’t think they’re necessary.

1. In the comment in publicationcmds.c,
typo :“explcitly” -> “explicitly.”

2. In publication.sql, CREATE TABLE tbl_plain(a int);;
has an extra semicolon.

3. Will adding the following test for tbl_plain be redundant?
CREATE PUBLICATION testpub_conflict5 FOR TABLE tbl_plain, ONLY tbl_plain;
CREATE PUBLICATION testpub_conflict6 FOR TABLE ONLY tbl_plain, tbl_plain;

Apart from these the patch LGTM.

Best,
Kedar


Reply via email to