On Tue, Oct 20, 2026 at 11:23 PM kedar anavardekar <[email protected]> wrote: > > > PSA patch v4. > > Hi Peter, > Thank you for the patches, > I reviewed the patch v4 and these are minor points, so please feel > free to leave them out if you don’t think they’re necessary. > > 1. In the comment in publicationcmds.c, > typo :“explcitly” -> “explicitly.” > > 2. In publication.sql, CREATE TABLE tbl_plain(a int);; > has an extra semicolon. >
Hi Kedar. Thanks for catching those typos. > 3. Will adding the following test for tbl_plain be redundant? > CREATE PUBLICATION testpub_conflict5 FOR TABLE tbl_plain, ONLY tbl_plain; > CREATE PUBLICATION testpub_conflict6 FOR TABLE ONLY tbl_plain, tbl_plain; > AFAIK, those fall into the same category as the EXCEPT tests. e.g. they are not testing anything that is not already tested, but still it may be better to include them for completeness and to prevent people from wondering why they are absent. Anyway, I have added them to patch v5. PSA patch v5. ====== Kind Regards, Peter Smith. Fujitsu Australia
v5-0001-Error-if-same-table-has-ONLY-mismatch.patch
Description: Binary data
