Hi Henson, Thanks for the review and for testing the patch.
> The strongest case is VARIADIC, where a dump from master does not restore > even without > adding an overload later: > Attached v2 adds the `VARIADIC` case, including view recreation with pretty-printing both enabled and disabled, and the column-default test to cover `showimplicit = false`. The default still deparses as `ROW(1, 2)`. The implementation is unchanged from v1. > Agreed. I tried 15-19: there is only an easily fixed conflict, and no > code changes are needed: > As you noted, 19 takes the patch unchanged; on 15-18 I omitted only the `updatable_views.out` hunk. The attachments are alternatives: the main patch is for master and 19; the `nocfbot-` patch is for 15-18. They should be applied separately, not as a series. I agree about keeping the `EXPLAIN` changes. Thanks also for clarifying the overlap with #7452 [1]. Regards, Sho [1] https://commitfest.postgresql.org/patch/7452/ -- ======================================= *Sho Ito (Sean)* E-mail: [email protected] LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/ <https://www.linkedin.com/in/sho-ito-0628/>* GitHub: https://github.com/sean0628/ =======================================
nocfbot-v2-0001-PG15_PG18-Preserve-implicit-composite-casts-in-ROW-deparse.patch
Description: Binary data
v2-0001-Preserve-implicit-composite-casts-in-ROW-deparse.patch
Description: Binary data
