Hello, At Thu, 19 Nov 2026 23:41:09 -0500, Sho Ito <[email protected]> wrote in > Attached v2 adds the `VARIADIC` case, including view recreation with > pretty-printing both enabled and disabled, and the column-default test > to cover `showimplicit = false`. The default still deparses as > `ROW(1, 2)`. The implementation is unchanged from v1.
The change itself looks good to me, and the tests seem sufficient. However, I think the comment might be more useful if it focused on explaining why RECORDOID can be excluded even when showimplicit is true. For example: > A bare ROW() expression has type RECORD, so omitting the cast to > RECORD even when showimplicit is true does not affect overload > resolution on reparse. Regards, -- Kyotaro Horiguchi NTT Open Source Software Center
