On Fri, Nov 20, 2026 at 2:48 AM Daniel Gustafsson <[email protected]> wrote:

> > On 16 Nov 2026, at 20:13, Stepan Neretin <[email protected]> wrote:
>
> > Attached is a small rebase on current master, with the TAP coverage
> > folded into "005_same_timeline.pl".  No behaviour change outside
> > assertion builds.
>
>  use warnings FATAL => 'all';
> +use PostgreSQL::Test::Cluster;
>  use PostgreSQL::Test::Utils;
>
> The proposed TAP test breaks the current model where tests use the
> infrastructure in the RewindTest module.  Is there a reason why this test
> should be different?
>
> > Does this still seem worth committing?
>
> From reading over the thread in which Heikki concluded it was a bogus
> Assert,
> I'd say it's still worth committing.  I do think the TAP test should be in
> line
> with the other pg_rewind tests though.
>
> --
> Daniel Gustafsson
>


Hi Daniel,

Thanks for looking. Folding this into 005 was a mistake.

RewindTest is the usual primary/standby/promote/rewind cycle, and this
needs an older base backup as the target. Same reason 008 skips it. v2
leaves 005 alone and puts the coverage in 012_target_is_ancestor.pl,
along the lines of Heikki's earlier test.

Assert fix itself is unchanged.

Attached.

Reply via email to