> On 20 Nov 2026, at 08:56, Michael Paquier <[email protected]> wrote:
> 
> On Thu, Nov 19, 2026 at 08:47:51PM +0100, Daniel Gustafsson wrote:
>> From reading over the thread in which Heikki concluded it was a bogus Assert,
>> I'd say it's still worth committing.  I do think the TAP test should be in 
>> line
>> with the other pg_rewind tests though.
> 
> Dropping the assertion sounds good.

Thanks for confirming, I'll go ahead with this.

> My first impression about the test was that it did not seem like it
> was worth the cycles, but I'm convinced by its coverage on closer
> read: cases for direct ancestors based on backups are interesting to
> have.

That was my initial reaction too, but I also came to the conclusion that this
test does in fact cover a case which doesn't have good coverage today.

--
Daniel Gustafsson



Reply via email to