On Fri, Nov 9, 2018 at 1:03 AM Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > On 2018-Nov-07, Amit Langote wrote: > > > I think the result in this case should be an error, just as it would in > > the regular inheritance case. > > > > create table parent (a text); > > create table child (a text collate "en_US") inherits (parent); > > NOTICE: merging column "a" with inherited definition > > ERROR: column "a" has a collation conflict > > DETAIL: "default" versus "en_US" > > > > In fact, I see that ATTACH PARTITION rejects a partition if collations > > don't match. > > Hmm, I'm thinking perhaps we shouldn't backpatch this part. It's > obviously a bug, but we might break somebody's working apps. Therefore > I think I'd rather leave it out of the current bugfix and commit > separately.
Okay, that may be fine because nothing wrong is happening by silently ignoring the partition's specified collation. Thanks, Amit