On Wed, Jan 23, 2019 at 1:16 PM Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2019/01/23 4:51, Andres Freund wrote: > > On 2019-01-22 13:43:32 +0900, Amit Langote wrote: > >> Attached find a patch to fix $subject. > > > > Thanks, pushed to master and 11. > > Thank you.
It's not only the ending that's wrong. Here are some more source files whose IDENTIFICATION heading doesn't exactly match their path: $ git grep -A 1 IDENTIFICATION | grep -v IDENTIFICATION | grep -v -- -- | sed 's/-[^a-z][^a-z]*/ /' | awk '{ if ($1 != $2) print; }' doc/src/sgml/lobj.sgml src/test/examples/testlo.c src/backend/catalog/pg_publication.c pg_publication.c src/backend/commands/publicationcmds.c publicationcmds.c src/backend/commands/subscriptioncmds.c subscriptioncmds.c src/backend/jit/llvm/llvmjit_inline.cpp src/backend/lib/llvmjit/llvmjit_inline.cpp src/backend/jit/llvm/llvmjit_wrap.cpp src/backend/lib/llvm/llvmjit_wrap.cpp src/backend/optimizer/util/appendinfo.c src/backend/optimizer/path/appendinfo.c src/backend/optimizer/util/inherit.c src/backend/optimizer/path/inherit.c src/backend/replication/logical/logicalfuncs.c src/backend/replication/logicalfuncs.c src/backend/replication/logical/reorderbuffer.c src/backend/replication/reorderbuffer.c src/backend/replication/logical/snapbuild.c src/backend/replication/snapbuild.c src/backend/replication/pgoutput/Makefile src/backend/replication/pgoutput src/backend/utils/adt/version.c src/include/replication/pgoutput.h pgoutput.h This could be really confusing for erm, future people reading a dot matrix print-out of the source code? -- Thomas Munro http://www.enterprisedb.com