On Wed, Jan 23, 2019 at 01:37:41PM +1300, Thomas Munro wrote: > It's not only the ending that's wrong. Here are some more source > files whose IDENTIFICATION heading doesn't exactly match their path:
Good point. > $ git grep -A 1 IDENTIFICATION | grep -v IDENTIFICATION | grep -v -- > -- | sed 's/-[^a-z][^a-z]*/ /' | awk '{ if ($1 != $2) print; }' > doc/src/sgml/lobj.sgml src/test/examples/testlo.c Some noise? > src/backend/catalog/pg_publication.c pg_publication.c > src/backend/commands/publicationcmds.c publicationcmds.c > src/backend/commands/subscriptioncmds.c subscriptioncmds.c > src/backend/jit/llvm/llvmjit_inline.cpp > src/backend/lib/llvmjit/llvmjit_inline.cpp > src/backend/jit/llvm/llvmjit_wrap.cpp src/backend/lib/llvm/llvmjit_wrap.cpp > src/backend/replication/logical/logicalfuncs.c > src/backend/replication/logicalfuncs.c > src/backend/replication/logical/reorderbuffer.c > src/backend/replication/reorderbuffer.c > src/backend/replication/logical/snapbuild.c > src/backend/replication/snapbuild.c > src/backend/replication/pgoutput/Makefile src/backend/replication/pgoutput > src/include/replication/pgoutput.h pgoutput.h Logical decoding, JIT and logical replication. > src/backend/optimizer/util/appendinfo.c > src/backend/optimizer/path/appendinfo.c > src/backend/optimizer/util/inherit.c src/backend/optimizer/path/inherit.c These two are recent, from b60c397. > src/backend/utils/adt/version.c This complains about the indentation? > This could be really confusing for erm, future people reading a dot > matrix print-out of the source code? Yes, it would be nice to make all that consistent. Perhaps the authors of the related commits would prefer fix that themselves? -- Michael
signature.asc
Description: PGP signature