Hi, Am Montag, den 18.02.2019, 12:24 +0900 schrieb Michael Paquier: > On Sun, Feb 17, 2019 at 09:00:29PM +0100, Michael Banck wrote: > > Well, pg_rewind is also using kB, so should I switch it back to that? > > I am not sure which one is better, sorry :) > > There is an argument for switching pg_rewind to use MB as well. I > don't expect pg_rewind to transfer gigs of data, but it could make the > maths harder for a newcomer if it transfers a lot of data.
Right, I think it makes more sense for pg_basebackup and pg_verify_checksums as they go over the whole cluster than for pg_rewind, but being consistent is also worth something. > > It looks like the progress reporting is otherwise quite similar, so what > > exactly did you have in mind? > > I was thinking about a routine in src/common/ or such at this time. > The tools have separate goals though, so it looks sensible as well to > keep two routines. I am fine to let that up to you. I'll leave it as-is for now, but will see whether this can be improved in a follow-up patch. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz