I don't much like the code that does pg_log_error("%s", something);
because then the string "%s" is marked for translation. Maybe we should consider a variant that takes a straight string literal instead of a sprintf-style fmt to avoid this problem. We'd do something like pg_log_error_v(something); which does not call _() within. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services