On 2019-Apr-02, Tom Lane wrote: > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > I don't much like the code that does > > pg_log_error("%s", something); > > > because then the string "%s" is marked for translation. > > Uh, surely we've got hundreds of instances of that in the system already?
Actually, we don't have that many, but there are more than I remembered there being -- my memory was telling me that I had erradicated them all in commit 55a70a023c3d but that's sadly misinformed. Seeing this (and also because the API would become nastier than I thought it would), I'll leave this stuff be for now. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services