Thanks for committing those portions. On Fri, Apr 19, 2019 at 05:00:26PM +0900, Michael Paquier wrote: > I am particularly referring to patches 0005 > (publications use "a superuser" in error messages as well which could > be fixed as well?),
I deliberately avoided changing thesee "errhint" messages, since the style guide indicates that errhint should be a complete sentence. pryzbyj@pryzbyj:~/src/postgres$ git grep 'must be a superuser' |grep errhint src/backend/commands/event_trigger.c: errhint("The owner of an event trigger must be a superuser."))); src/backend/commands/foreigncmds.c: errhint("The owner of a foreign-data wrapper must be a superuser."))); src/backend/commands/publicationcmds.c: errhint("The owner of a FOR ALL TABLES publication must be a superuser."))); src/backend/commands/subscriptioncmds.c: errhint("The owner of a subscription must be a superuser."))); Justin