On Fri, Jun 21, 2019 at 11:50 AM Amit Khandekar <amitdkhan...@gmail.com> wrote: > > This definitely needs to be expanded, and follow the message style > > guideline. > > This message , with the v8 patch, looks like this : > ereport(LOG, > (errmsg("Dropping conflicting slot %s", NameStr(slotname)), > errdetail("%s", reason))); > where reason is a char string.
That does not follow the message style guideline. https://www.postgresql.org/docs/12/error-style-guide.html >From the grammar and punctuation section: "Primary error messages: Do not capitalize the first letter. Do not end a message with a period. Do not even think about ending a message with an exclamation point. Detail and hint messages: Use complete sentences, and end each with a period. Capitalize the first word of sentences. Put two spaces after the period if another sentence follows (for English text; might be inappropriate in other languages)." -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company