On Fri, Sep 13, 2019 at 10:42 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, Sep 13, 2019 at 09:59:40AM +0530, Amit Kapila wrote: > > I think that is what we have not done in one of the cases pointed by me. > > Thinking more about it, I see your point now. HEAP_LOCKED_UPGRADED is > not a direct combination of the other flags and depends on other > conditions, so we cannot make a combination of it with other things. > The three others don't have that problem. > > Attached is a patch to fix your suggestions. This also removes the > use of HEAP_XMAX_IS_LOCKED_ONLY which did not make completely sense > either as a "raw" flag. While on it, the order of the flags can be > improved to match more the order of htup_details.h > > Does this patch address your concerns? >
Yeah, but I think we should also try to see what we want to do about 'decode_combined' flag-related point, maybe we can adapt to what Alvaro has purposed? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
