On Thu, Sep 19, 2019 at 11:47 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, Sep 19, 2019 at 10:25 AM Fabien COELHO <coe...@cri.ensmp.fr> wrote: > > Hello Amit, > > > > >> Yes, on -i it will fail because the syntax will not be recognized. > > > > > > Maybe we should be checking the server version, which would allow to > > > produce more useful error messages when these options are used against > > > older servers, like > > > > > > if (sversion < 10000) > > > fprintf(stderr, "cannot use --partitions/--partitions-method > > > against servers older than 10"); > > > > > > We would also have to check that partition-method=hash is not used > > > against v10. > > > > > > Maybe overkill? > > > > Yes, I think so: the error detection and messages would be more or less > > replicated from the server and would vary from version to version. > > > > Yeah, but I think Amit L's point is worth considering. I think it > would be good if a few other people can also share their suggestion on > this point. Alvaro, Dilip, anybody else following this thread, would > like to comment? It is important to know others opinion on this > because this will change how pgbench behaves with prior versions.
IMHO, we don't need to invent the error handling at the pgbench instead we can rely on the server's error. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
