> > On 2019-Sep-20, Paul Guo wrote: > > > The patch series failed on Windows CI. I modified the Windows build file > to > > fix that. See attached for the v7 version. > > Thanks. > > Question about 0003. If we specify --skip-clean-shutdown and the cluter > was not cleanly shut down, shouldn't we error out instead of trying to > press on?
pg_rewind would error out in this case, see sanityChecks(). Users are expected to clean up themselves if they use this argument.