On 2019-Oct-03, Amit Langote wrote: > There may not really be any problem with the commit itself, but I > suspect that the new types of dependencies (or the way > findDependentObject() analyzes them) don't play well with inheritance > recursion of ATExecDropColumn(). Currently, child columns (and its > dependencies) are dropped before the parent column (and its > dependencies). By using the attached patch which reverses that order, > the error goes away, but I'm not sure that that's the correct > solution.
Hmm. I wonder if we shouldn't adopt the coding pattern we've used elsewhere of collecting all columns to be dropped first into an ObjectAddresses array, then use performMultipleDeletions. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
