The following review on our patch was posted on another thread, so I quote here. The tab completion is Hoshiai-san's work, so he will handle this issue.
Regards, Yugo Nagata. On Thu, 28 Nov 2019 13:00:05 +0900 nuko yokohama <nuko.yokoh...@gmail.com> wrote: > Hi. > > I'm using the "Incremental Materialized View Maintenance" patch and have > reported the following issues. > (https://commitfest.postgresql.org/25/2138/) > > To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, but the syntax > error when you run. > ("DROP MATERIALIZED VIEW" command can drop Incremental Materialozed view > normally.) > > > ramendb=# CREATE INCREMENTAL MATERIALIZED VIEW pref_count AS SELECT pref, > COUNT(pref) FROM shops GROUP BY pref; > SELECT 48 > ramendb=# \d pref_count > Materialized view "public.pref_count" > Column | Type | Collation | Nullable | Default > ---------------+--------+-----------+----------+--------- > pref | text | | | > count | bigint | | | > __ivm_count__ | bigint | | | > > ramendb=# DROP IN > INCREMENTAL MATERIALIZED VIEW INDEX > ramendb=# DROP INCREMENTAL MATERIALIZED VIEW pref_count; > 2019-11-27 11:51:03.916 UTC [9759] ERROR: syntax error at or near > "INCREMENTAL" at character 6 > 2019-11-27 11:51:03.916 UTC [9759] STATEMENT: DROP INCREMENTAL > MATERIALIZED VIEW pref_count; > ERROR: syntax error at or near "INCREMENTAL" > LINE 1: DROP INCREMENTAL MATERIALIZED VIEW pref_count; > ^ > ramendb=# DROP MATERIALIZED VIEW pref_count ; > DROP MATERIALIZED VIEW > ramendb=# > > > Regard. -- Yugo Nagata <nag...@sraoss.co.jp> -- Yugo Nagata <nag...@sraoss.co.jp>
