That is what my patch does: it tests prompts, tab completion, help,
command options… and I added tests till I covered most psql source.

Well, I think that where possible we ought to test using the existing test infrastructure -- help, for example, seems like it could perfectly well be tested in src/test/regress/sql/psql.sql, or we could move stuff out to a new set of SQL test scripts under src/bin/psql/sql/,

I do not think it is a good idea, because help output is quite large, there are many of them, and we should certainly not want it stored repeatedly in output files for diffs. I rather trigger the output and only check for some related keywords, so that it fits TAP tests reasonably well.

--
Fabien.

Reply via email to