> On Jan 26, 2020, at 5:51 PM, Andrew Dunstan <andrew.duns...@2ndquadrant.com> > wrote: > >>> 0007 adds testing. >>> >>> I would appreciate somebody looking at the portability issues for 0007 >>> on Windows. >>> >> >> We'll need at a minimum something added to src/tools/msvc to build the >> test program, maybe some other stuff too. I'll take a look. > > > Patch complains that the 0007 patch is malformed: > > andrew@ariana:pg_head (master)*$ patch -p 1 < > ~/Downloads/v4-0007-Adding-frontend-tests-for-json-parser.patch > patching file src/Makefile > patching file src/test/Makefile > patching file src/test/bin/.gitignore > patching file src/test/bin/Makefile > patching file src/test/bin/README > patching file src/test/bin/t/001_test_json.pl > patch: **** malformed patch at line 201: diff --git > a/src/test/bin/test_json.c b/src/test/bin/test_json.c
I manually removed a stray newline in the patch file. I shouldn’t have done that. I’ve removed the stray newline in the sources, committed (with git commit —amend) and am testing again, which is what I should have done the first time…. Ok, the tests pass. Here are those two patches again, both regenerated with a fresh invocation of ‘git format-patch’. — Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
v5-0006-Relocating-jsonapi-to-common.patch
Description: Binary data
v5-0007-Adding-frontend-tests-for-json-parser.patch
Description: Binary data
