> On Mar 16, 2020, at 5:14 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote:
>
> On 2020-Mar-16, Mark Dilger wrote:
>
>> Hackers,
>>
>> While working on object access hooks, I noticed several locations where I
>> would expect the hook to be invoked, but no actual invocation. I think this
>> just barely qualifies as a bug. It's debatable because whether it is a bug
>> depends on the user's expectations and whether not invoking the hook in
>> these cases is defensible. Does anybody have any recollection of an
>> intentional choice not to invoke in these locations?
>
> Hmm, possibly the create-time calls are missing.
It looks to me that both the create and alter calls are missing.
>
> I'm surprised about the InvokeObjectDropHook calls though. Doesn't
> deleteOneObject already call that? If we have more calls elsewhere,
> maybe they are redundant. I think we should only have those for
> "shared" objects.
Yeah, you are right about the drop hook being invoked elsewhere for dropping
ACCESS METHOD and STATISTICS. Sorry for the noise.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
