On 2020-May-14, Robert Haas wrote: > I have a question about what you mean here by "arbitrarily." > > If you mean that we shouldn't have the buildfarm run the proposed heap > corruption checker against heap pages full of randomly-generated > garbage, I tend to agree. Such a test wouldn't be very stable and > might fail in lots of low-probability ways that could require > unreasonable effort to find and fix.
This is what I meant. I was thinking of blocks generated randomly. > If you mean that we shouldn't have the buildfarm run the proposed heap > corruption checker against any corrupted heap pages at all, I tend to > disagree. Yeah, IMV those would not be arbitrarily corrupted -- instead they're crafted to be corrupted in some specific way. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services