On Tue, Jun 9, 2020 at 9:28 AM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote:
> On 2020-06-09 09:19, Michael Paquier wrote: > > On Mon, Jun 08, 2020 at 02:44:31PM +0200, Peter Eisentraut wrote: > >> both contain a TAP skip notice "symlinks not supported on Windows". > >> > >> This is untrue. Symlinks certainly work on Windows, and we have other > TAP > >> tests using them, for example for tablespaces. > > > >> pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just > remove > >> the skip stuff. My attached patch does that. > > > > What's the version of your perl installation on Windows? With 5.22, I > > am still seeing that symlink() is not implemented, causing the tests > > of pg_rewind to blow in flight with your patch (MSVC 2015 here). > > I was using MSYS2 and the Perl version appears to have been 5.30.2. > Note sure which one of these two factors makes the difference. > The difference seems to be MSYS2, it also fails for me if I do not include 'Win32::Symlink' with Perl 5.30.2. Regards, Juan José Santamaría Flecha
