On 6/17/20 6:32 AM, Magnus Hagander wrote: > > > > > > In looking at this I realize we also have exactly one thing referred > to as "blacklist" in our codebase, which is the "enum blacklist" (and > then a small internal variable in pgindent). AFAICT, it's not actually > exposed to userspace anywhere, so we could probably make the attached > change to blocklist at no "cost" (the only thing changed is the name > of the hash table, and we definitely change things like that in normal > releases with no specific thought on backwards compat). > >
I'm not sure I like doing s/Black/Block/ here. It reads oddly. There are too many other uses of Block in the sources. Forbidden might be a better substitution, or Banned maybe. BanList is even less characters than BlackList. I know, bikeshedding here. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
