On Wed, Jul 22, 2020 at 06:58:33AM +0200, Antonin Houska wrote: > Tom Lane <t...@sss.pgh.pa.us> wrote: > > > I don't particularly want to remove the field, but we ought to > > change or remove the comment. > > I'm not concerned about the existence of the field as well. The comment just > made me worried that I might be missing some fundamental concept. Thanks for > your opinion.
I have developed the attached patch to address this. -- Bruce Momjian <br...@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee
diff --git a/src/include/access/heapam_xlog.h b/src/include/access/heapam_xlog.h index aa17f7df84..38683893c0 100644 --- a/src/include/access/heapam_xlog.h +++ b/src/include/access/heapam_xlog.h @@ -137,8 +137,7 @@ typedef struct xl_heap_truncate * or updated tuple in WAL; we can save a few bytes by reconstructing the * fields that are available elsewhere in the WAL record, or perhaps just * plain needn't be reconstructed. These are the fields we must store. - * NOTE: t_hoff could be recomputed, but we may as well store it because - * it will come for free due to alignment considerations. + * FYI, t_hoff could potentially be recomputed. */ typedef struct xl_heap_header {