On 2020-Sep-01, Justin Pryzby wrote: > On Tue, Sep 01, 2020 at 11:40:18AM -0400, Alvaro Herrera wrote:
> > The advantage of using a parenthesized option list is that you can add > > *further* options without making the new keywords reserved. Of course, > > we already reserve CONCURRENTLY and VERBOSE pretty severely, so there's > > no change. If you wanted REINDEX FLUFFY then it wouldn't work without > > making that at least type_func_name_keyword I think; but REINDEX > > (FLUFFY) would work just fine. And of course the new feature at hand > > can be implemented. > > The question isn't whether to use a parenthesized option list. I realized > that > long ago (even though Alexey didn't initially like it). Check 0002, which > gets > rid of "bool concurrent" in favour of stmt->options&REINDEXOPT_CONCURRENT. Ah! I see, sorry for the noise. Well, respectfully, having a separate boolean to store one option when you already have a bitmask for options is silly. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
