On Wed, Sep 9, 2020 at 6:42 PM Alexey Kondratov <a.kondra...@postgrespro.ru> wrote: > On 2020-09-09 11:45, Andrey V. Lepikhov wrote: > > This does not seem very convenient and will lead to errors in the > > future. So, I agree with Amit. > > And InitResultRelInfo() may set ri_usesMultiInsert to false by default, > since it's used only by COPY now. Then you won't need this in several > places: > > + resultRelInfo->ri_usesMultiInsert = false; > > While the logic of turning multi-insert on with all the validations > required could be factored out of InitResultRelInfo() to a separate > routine.
Interesting idea. Maybe better to have a separate routine like Alexey says. -- Amit Langote EnterpriseDB: http://www.enterprisedb.com
