On Sat, Sep 19, 2020 at 1:30 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > I wrote: > > ISTM that getting rid of the division obviates the concern that the > > nentries condition is too expensive,
True, that comment needed to go. > Also, we could make it slightly cheaper yet, by changing the condition > to > > hctl->freeList[0].nentries > (long) (hctl->max_bucket) > > ie drop the +1. I'd argue that this is actually a more faithful > rendition of the previous condition, since what we had before was > basically > > hctl->freeList[0].nentries >= (long) (hctl->max_bucket + 1) Agreed, and done. Thanks!
