On Mon, Sep 21, 2020 at 5:23 PM Ajin Cherian <itsa...@gmail.com> wrote: > > On Mon, Sep 21, 2020 at 9:24 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > I think we need to call ReorderBufferAbort at least to clean up the > > TXN. Also, if what you are saying is correct then that should be true > > without this patch as well, no? If so, we don't need to worry about it > > as far as this patch is concerned. > > Yes, that is true. So will change this check to: > > if (TransactionIdIsValid(xid) && > ReorderBufferTxnIsPrepared(ctx->reorder, xid, parsed->twophase_gid) >
Yeah and add the Assert for skip conditions as asked above. -- With Regards, Amit Kapila.
